Remove redudant issue LoadAttributes() calls (#2614 An error occurred )

models/issue.go

@@ -984,12 +984,7 @@ func GetIssueByRef(ref string) (*Issue, error) {
 		return nil, err
 	}
 
-	issue, err := GetIssueByIndex(repo.ID, index)
-	if err != nil {
-		return nil, err
-	}
-
-	return issue, issue.LoadAttributes()
+	return GetIssueByIndex(repo.ID, index)
 }
 
 // GetRawIssueByIndex returns raw issue without loading attributes by index in a repository.

routers/api/v1/repo/issue.go

@@ -39,12 +39,6 @@ func ListIssues(ctx *context.APIContext) {
 		return
 	}
 
-	err = models.IssueList(issues).LoadAttributes()
-	if err != nil {
-		ctx.Error(500, "LoadAttributes", err)
-		return
-	}
-
 	apiIssues := make([]*api.Issue, len(issues))
 	for i := range issues {
 		apiIssues[i] = issues[i].APIFormat()